Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
139 stars 2 forks source link

Add video support for Niconico #2993

Open Zozokasu opened 1 month ago

Zozokasu commented 1 month ago

Is your feature request related to a problem? Please describe.

Niconico links seem to be supported as video links, but they are not loaded properly. 2024-09-22 03 45 43 https://www.nicovideo.jp/watch/sm9

For this video, the video title are loaded properly, but the video is not displayed.

Describe the solution you'd like

Support Niconico videos natively.

Describe alternatives you've considered

Download, (conbine audio and video,) and paste video file into resonite.

Additional Context

Niconico is a major video platform in Japan. yt-dlp seems to be supported Niconico since 2024.08.06. https://github.com/yt-dlp/yt-dlp/releases/tag/2024.08.06

Requesters

zozokasu

yoshiyoshyosh commented 1 month ago

some additional context: nicovideo doesn't provide a single file that contains both a video and audio stream, but rather separate video/audio tracks, which is either unsupported on the video player or would cause end-user delays to workaround. currently, yt-dlp chooses an audio-only stream as the "best" one to play, which doesn't work well with video importing

this is also why twitter videos don't have audio. we'll probably either need to wait until we have a better video player or find some way to real-time mux the video/audio in a streaming fashion? not sure