Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
139 stars 2 forks source link

Boolean to check what type of button press on physical button component #3001

Open AegisTheWolf opened 1 month ago

AegisTheWolf commented 1 month ago

Is your feature request related to a problem? Please describe.

When building a functioning piano in Resonite I designed it to have 2 ways of playing it: one with using press delta (how fast/hard the notes are played) and a simple click/press to play a note. While adding the functionality to determine how the keys are pressed (remote laser or physically) I noticed the physical button component lacks the distinction between remotely pressing it via lasers and desktop mode and physically pressing it with a tip touch source. Other components that are buttons have this distinction as a boolean output.

Describe the solution you'd like

If possible adding this distinction as a boolean on a physical button component to tell if its pressed remotely or physically would be ideal.

Describe alternatives you've considered

Alternatives were shown to me in a form of making a button in a menu to toggle between modes (I did this for now).

Or using a specific cast connected to the button events node plugged into a Not Null node checking the type of source the button was pressed with being written into a bool store as a input to check which way the button was pressed

Additional Context

No response

Requesters

Aegis_Wolf, JackTheFoxOtter

shiftyscales commented 1 month ago

Hmm- in the case of the PhysicalButton- a remote press will instantly set the pressing depth to 1 while a physical press will have values <1 before reaching its maximum depth.

Although in this case, it'd probably be best that you include two buttons, @AegisTheWolf - A PhysicalButton which accepts PhysicalTouch only, and a TouchButton which accepts RemoteTouch only.

This will let you tell which button is being interacted with directly.

Would that meet your needs for now?

AegisTheWolf commented 1 month ago

It can fix this issue and i might do that to make it easier to sort out, though having consistency with other button components would be good to have.