Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
139 stars 2 forks source link

Further Protoflux node categorization changes #302

Open ShrikeAlvaron opened 1 year ago

ShrikeAlvaron commented 1 year ago

Is your feature request related to a problem? Please describe.

There's a few outlying issues with node categorization in the node browser currently that weren't addressed previously in part to me not finding time to document them until now, here's the ones that stand out to me.

Describe the solution you'd like

Describe alternatives you've considered

These changes will align with the rest of the Protoflux categorization style so not sure about alternatives for most. The color packing nodes could just be put in Colors without the Packing sub-category but using it aligns with the Operators/Packing nodes. I'd be open to other nice names for FieldHook too; I think we should avoid using just Drive though to avoid confusion with actual Driver nodes.

Additional Context

No response

ProbablePrime commented 1 year ago

Thanks!

BlueCyro commented 1 year ago

Notably, the PlayOneShot nodes should also not be in "ProtoFlux/Runtimes/Execution/Nodes/FrooxEngine/Audio"

But instead, they should probably be back in the Media folder like they were previously.

Right now they're within a "FrooxEngine" folder in the main protoflux directory.

ProbablePrime commented 1 year ago

Notably, the PlayOneShot nodes should also not be in "ProtoFlux/Runtimes/Execution/Nodes/FrooxEngine/Audio"

But instead, they should probably be back in the Media folder like they were previously.

Right now they're within a "FrooxEngine" folder in the main protoflux directory.

That's in another issue, thank you

ProbablePrime commented 1 year ago

Hooks are different from Drives, so we won't be renaming FieldHook we'll also leave this in core for now. I need to understand how that node is used in practice more before moving it.

The rest have pending updates :)

ShrikeAlvaron commented 1 year ago

Not renaming it is fine, but from my understanding FieldHook is functionally equivalent to the old Drive node letting you turn a drive on a field on and off (and get a pulse when something else tries writing it)