search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
141 stars 2 forks source link

Limit RTF in direct messages/Add the ability to delete messages more easily #3090

Open 3x1t-5tyl3 opened 1 month ago

3x1t-5tyl3 commented 1 month ago

Describe the bug?

When sending messages there's currently no text limit thus this can be abused to become almost unable to read a chat, send items, invite ect.

To Reproduce

1: Send a txt with <size=LARGE_NUMBER>whatever 1a: This can also be large text excerpts. 2: Observe as unusually large text makes you unable to scroll properly up or down requiring a facet to delete all messages in order for it to become usable.

Expected behavior

Limit text amount, size, color and other RTF tags to a reasonable limit to make sure dm's stay readable.

Screenshots

No response

Resonite Version Number

Beta 2024.10.8.1349

What Platforms does this occur on?

Windows, Linux, Android / Quest

What headset if any do you use?

Doesn't matter.

Log Files

/

Additional Context

It is also fine keeping it and allowing the user to delete messages by themselves with a button (and confirmation). Prefferably both, sanitize RTF and allow for message deletion.

Reporters

3x1t_5tyl3, Xau

shiftyscales commented 1 month ago

There may be some effort we could place into text sanitization at some point, but we likely wouldn't put much more effort into the rest of your request at this time- a lot of that would likely be implicitly covered by or considered with the contacts UI rework #1116.

Frooxius commented 1 month ago

The RTF limit and message deleting should be two separate issues.

We do have limit on the amount of text, though it's fairly large. We can add mechanisms to prevent abusing RTF tags to make the UI unusable.