Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
141 stars 2 forks source link

DestroyWithoutChildren does not respect en-disabled state #3120

Open 3x1t-5tyl3 opened 1 month ago

3x1t-5tyl3 commented 1 month ago

Describe the bug?

When disabling the "Root" slot where the component is located or the component itself it does not disable it's own behaviour.

I'm currently going through old issues I opened previously. This was one of them

To Reproduce

1: Make an empty 2: Add a child 3: Add the component DestroyWithoutChildren 4: Disable the slot and/or component 5: It still deletes itself.

Expected behavior

To not delete itself.

Screenshots

No response

Resonite Version Number

Beta 2024.10.23.15

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

N/A Empty log.

Additional Context

No response

Reporters

3x1t_5tyl3

shiftyscales commented 1 month ago

All components have an "Enabled" bool as it is part of the component template on which all components are made- not all components however have any functionality tied into that property- as such I believe this is likely a case where this is an enhancement / feature request and not a bug.

3x1t-5tyl3 commented 4 weeks ago

All components have an "Enabled" bool as it is part of the component template on which all components are made- not all components however have any functionality tied into that property- as such I believe this is likely a case where this is an enhancement / feature request and not a bug.

Gotcha! If I happen to find more of such components should I mark them as a new feature directly?

shiftyscales commented 4 weeks ago

Unless it's a regression / you know that it was working previously in an earlier version of Resonite- it's generally safer to assume most components won't have a behaviour tied to it by default- typically they just get added as-needed when a user submits a request like this.

There's going to be a lot of them- so I wouldn't suggest going out of your way to try to look for them- they aren't hard to find.