search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
141 stars 2 forks source link

Importing files from in game downloades them to the resonite game folder #3230

Open Redd56 opened 5 days ago

Redd56 commented 5 days ago

Describe the bug?

when importing a raw file from in game (as in when you select raw file from the import dialog) then someone else imports that raw file it creates (what im guessing is supposed to be temporarily version of) that file in the steamapps/common/resonite folder essential. then just leaves it there. this both bloats the game files as theres now just an model/texture/video file in the games files. and

To Reproduce

get an fbx and place it in game. set as raw. have someone else import it via the context menu. see that they now have the model you payed 20 bucks on gumroad for on their pc

Expected behavior

it to either place it in a temp folder and that folder to be cleared on game restart or it to clean itself up right afterwords

Screenshots

Image

Resonite Version Number

2024.11.19.479

What Platforms does this occur on?

Windows

What headset if any do you use?

n/a

Log Files

DESKTOP-5DC208J - 2024.11.19.479 - 2024-11-28 16_11_40.log

Additional Context

it for some reason also gives it a random )im guessing hashed) name

also ignore the crash the game crashed when i alt f4ed for some reason

Reporters

Redd56, Chundelac

shiftyscales commented 5 days ago

get an fbx and place it in game. set as raw. have someone else import it via the context menu. see that they now have the model you payed 20 bucks on gumroad for on their pc

I do not understand how this is a bug, @Redd56.

If you are importing the asset in a raw format, they could already just save the raw asset directly in Resonite- they wouldn't need to extract it. Likewise- how would they import it if the file didn't exist on their PC in any form?

If you do not want other users to have the raw file, you shouldn't import the raw file into a session with other users you do not trust to have it.

Dusty-Sprinkles commented 5 days ago

I'm not sure if they were unclear but this applies to hitting the "Import" on raw files ingame, though even if the avatar issues aren't a problem it does create files that look like they're supposed to be temporary but don't delete them so it might be worth keeping open

Redd56 commented 4 days ago

Thats the main thing it creates fhahfhsh47nd77472fndn.fbx in steamapps common resonite. And doesnt clean it up afterwords. I know it needs to be on the pc somewhere to import but it should clean up afterwords if it isnt a dedicated folder for imports.

ProbablePrime commented 3 days ago

Sorry for the back and forth here, but yes I think this is a bug.

I was in this area to fix a security bug which is highly related to this issue and it might be some result of me fixing that.