Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
135 stars 2 forks source link

Closing the home world while it is focused won't actually close it until you focus to a different world #380

Open JackTheFoxOtter opened 11 months ago

JackTheFoxOtter commented 11 months ago

Describe the bug?

This is something I've so far only experienced with my currently favorited home. Attempting to close the world will disconnect all other connected players, but won't actually close the world. Clicking close world again doesn't work either.

To Reproduce

Launch Resonite, wait a moment, attempt to close the home world.

Expected behavior

The home world should close properly.

Screenshots

No response

Resonite Version Number

2023.10.20.831

What Platforms does this occur on?

Windows

What headset if any do you use?

Valve Index

Log Files

J4-C - 2023.10.20.831 - 2023-10-21 17_13_22.log

I pressed F3 before closing the world via the "Close World" facet (discarding changes), but the log doesn't show anything.

Additional Context

Attempting to close the home world through the world browser or through the "Worlds you're in" facet produces the same result, the world doesn't close. This works properly for any world that isn't the current home world.

Reporters

@JackTheFoxOtter

Nytra commented 11 months ago

Try focusing to a different world such as your local home after you click close world.

JackTheFoxOtter commented 11 months ago

Try focusing to a different world such as your local home after you click close world.

Oh intersting. Focusing on a different world does indeed cause the world to close after I clicked the "Close World" button.

Nytra commented 11 months ago

Yes so I think this has been an issue since Neos. I always had to focus to my local home in order to close my cloud home.

MargoSizemore commented 11 months ago

I've experienced this too

JackTheFoxOtter commented 8 months ago

Updated title to better reflect the underlying issue.

Frooxius commented 8 months ago

How are you closing the home exactly?

jae1911 commented 8 months ago

I can reproduce that using the shortcut to leave worlds on desktop (SHIFT + double tap ESC) which should close the world immediately but doesn't.

JackTheFoxOtter commented 8 months ago

Through the world browser. Using the "Close World" facet on Dash's home page does close it immediately, but closing it through the world browser (or the WorldsYou'reIn-Facet) will not close it until you actually focus to a different session.

shiftyscales commented 8 months ago

It seems like it might depend on how the world was opened, @Frooxius.

Opening the home world with the facet on the dashboard causes this issue to occur.

https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/54213390/3f85c3f5-d997-4d14-a948-aac903fa8ab0

SHIFTY-LAPTOP - 2024.1.26.627 - 2024-01-26 11_40_34.log

Seemingly it works as intended if the world loads as part of the startup sequence.

https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/54213390/02cdb188-39f9-4255-ac80-30f288e3bc8a

SHIFTY-LAPTOP - 2024.1.26.627 - 2024-01-26 11_53_23.log

VirgilCore commented 8 months ago

@shiftyscales nope. This bug happens to me with the startup home world too. Its not just the default cloud home, its any wold you have set as "home"

shiftyscales commented 8 months ago

Well, as I demonstrated above, that is clearly not the case- so there must be another factor, @VirgilCore. As shown in the second video I linked above- loading into my favourited cloud home causes the issue to occur when I open that world with the facet on my dash, but not while on a fresh start of the engine.

If you watched the video- it isn't the default cloud home- it's my own personal favourited world.

If your experience differs, then please provide video, log files, etc. that demonstrate that happening to you.

VirgilCore commented 8 months ago

When i get home, i will send video and logs. This problem happens for the world opened on engine start. (Also, no need to be condescending)

shiftyscales commented 8 months ago

Thank you for the feedback, @VirgilCore. I've isolated some additional details of this bug because of your comment.

If a new world is opened after the engine, and cloud home have loaded (e.g. opening a new gridspace), the cloud home will not close properly, similar to the first case in which it is opened by the home facet.

https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/54213390/a23f1ebe-6407-4ebc-b476-f60395a31fd9

SHIFTY-LAPTOP - 2024.1.26.627 - 2024-01-26 12_23_24.log

However, if you close and re-open your dash between exiting each world, it seems to work as expected.

https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/54213390/974bd668-66ed-4064-a029-825a8c7ce62a

SHIFTY-LAPTOP - 2024.1.26.627 - 2024-01-26 12_24_50.log