Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
134 stars 2 forks source link

Setting VertexColorInterpolationSpace to sRGBAlpha prevents materials (e.g. XiexeToon/Unlit) from updating properly #388

Open TeknoCatron opened 10 months ago

TeknoCatron commented 10 months ago

Describe the bug?

Once users cycle through the VertexColorInterpolationSpace and hit sRGBAlpha, all functions of the Xiexe Toon displaying properly break. Updates on the material Main Texture are no longer being visually updated and the material is permanent broken. Even after saving in cloud storage.

To Reproduce

  1. Create new Xiexie toon material (or use an existing one on avatar/objects)
  2. Cycle through the VertexColorInterpolationSpace to sRGBAlpha

The moment it is set on sRGBAlpha the material disable's itself and any changes made to the main texture no longer update. Even if the material is set back to Enabled.

Expected behavior

It not to cause issues when users cycle through the VertexColorInterpolationSpace. If it's not implemented, remove it for all I care. But user char1ika1 found it and came up to me with the issue.

Screenshots

2023-10-22 03 33 25

Resonite Version Number

Beta 2023.10.20.831

What Platforms does this occur on?

Windows

What headset if any do you use?

Vive Pro Eye | Index | Desktop

Log Files

ERU - 2023.10.20.831 - 2023-10-21 20_08_41 char1ika1.txt

Additional Context

Material to look for in the log file is IDEE66E01 This gives a clear indication on how it tripped.

Reporters

char1ika1 (Discord UserID: 332046986104537088) Tekno Catron (Dicord UserID: 281806404891836416)

shiftyscales commented 10 months ago

The log file appears to be incomplete, @TeknoCatron. Did you close Resonite before submitting it?

If possible, please create and submit an additional replication log file by launching resonite- performing the bug, and closing Resonite without doing anything else (ideally in a default gridspace or the local home/without your favourited avatar equipped).

The relevant exception otherwise seems to have been captured at line 90058. So I'll be seeking input on this one from @Geenz.

5:21:16 AM.195 ( 72 FPS)    Exception when Updating object: Element: IDEE66E01, Type: FrooxEngine.XiexeToonMaterial, World: Tekno's Nest Constructing the Dutch Locale, IsRemoved: False, IsDestroyed: False, IsDisposed: False, Enabled: True
Element: IDEE5FC01, Type: FrooxEngine.Slot, World: Tekno's Nest Constructing the Dutch Locale, IsRemoved: False, Slot name: <color purple>Remesh V2.6 XIEXE V20230909.1805</color> - Assets, T: [0; 0; 0], R: [0; 0; 0; 1], S: [1; 1; 1], ActiveSelf: True, IsDestroyed: False
Element: ID80D00, Type: FrooxEngine.Slot, World: Tekno's Nest Constructing the Dutch Locale, IsRemoved: False, Slot name: Assets, T: [0; 0; 0], R: [0; 0; 0; 1], S: [1; 1; 1], ActiveSelf: True, IsDestroyed: False
Element: ID2400, Type: FrooxEngine.Slot, World: Tekno's Nest Constructing the Dutch Locale, IsRemoved: False, Slot name: Root, T: [0; 0; 0], R: [0; 0; 0; 1], S: [1; 1; 1], ActiveSelf: True, IsDestroyed: False
Element: ID0, Type: FrooxEngine.World, World: Tekno's Nest Constructing the Dutch Locale, IsRemoved: False

Exception:
System.Exception: Unsupported color profile for vertex coloration!
  at FrooxEngine.XiexeToonMaterial.UpdateKeywords (FrooxEngine.ShaderKeywords keywords) [0x001bf] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.MaterialProvider.UpdateMaterialAsset (FrooxEngine.Material asset) [0x00050] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.MaterialProviderBase`1[A].UpdateAsset (A asset) [0x0005e] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.DynamicAssetProvider`1[A].RunAssetUpdate () [0x00066] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.DynamicAssetProvider`1[A].UpdateAsset () [0x00008] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.AssetProvider`1[A].RefreshAssetState () [0x0004c] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.AssetProvider`1[A].OnChanges () [0x00000] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.ComponentBase`1[C].InternalRunApplyChanges (System.Int32 updateIndex) [0x00017] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.UpdateManager.ProcessChange (FrooxEngine.IUpdatable updatable) [0x00024] in <01bfddd6944e4ae6baa74476d9774428>:0 
  at FrooxEngine.UpdateManager.RunQueue[T] (System.Collections.Generic.Queue`1[T] queue, System.Action`1[T] action) [0x00009] in <01bfddd6944e4ae6baa74476d9774428>:0 
TeknoCatron commented 10 months ago

ERU - 2023.10.20.831 - 2023-10-24 05_20_22.log

Additional LOG as requested: Issue at 5:22:25 AM.211 (144 FPS)

5:22:25 AM.211 (144 FPS) Exception when Updating object: Element: ID799C100, Type: FrooxEngine.XiexeToonMaterial, World: Tekno Catron Home, IsRemoved: False, IsDestroyed: False, IsDisposed: False, Enabled: True Element: ID7999B00, Type: FrooxEngine.Slot, World: Tekno Catron Home, IsRemoved: False, Slot name: Xiexe Toon, T: [0.04275487; 1.502427; 0.6825603], R: [0; 0.04367257; 0; 0.9990459], S: [1; 1; 1], ActiveSelf: True, IsDestroyed: False Element: ID2400, Type: FrooxEngine.Slot, World: Tekno Catron Home, IsRemoved: False, Slot name: Root, T: [0; 0; 0], R: [0; 0; 0; 1], S: [1; 1; 1], ActiveSelf: True, IsDestroyed: False Element: ID0, Type: FrooxEngine.World, World: Tekno Catron Home, IsRemoved: False

Exception: System.Exception: Unsupported color profile for vertex coloration! at FrooxEngine.XiexeToonMaterial.UpdateKeywords (FrooxEngine.ShaderKeywords keywords) [0x001bf] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.MaterialProvider.UpdateMaterialAsset (FrooxEngine.Material asset) [0x00050] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.MaterialProviderBase1[A].UpdateAsset (A asset) [0x0005e] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.DynamicAssetProvider1[A].RunAssetUpdate () [0x00066] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.DynamicAssetProvider1[A].UpdateAsset () [0x00008] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.AssetProvider1[A].RefreshAssetState () [0x0004c] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.AssetProvider1[A].OnChanges () [0x00000] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.ComponentBase1[C].InternalRunApplyChanges (System.Int32 updateIndex) [0x00017] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.UpdateManager.ProcessChange (FrooxEngine.IUpdatable updatable) [0x00024] in <01bfddd6944e4ae6baa74476d9774428>:0 at FrooxEngine.UpdateManager.RunQueue[T] (System.Collections.Generic.Queue1[T] queue, System.Action1[T] action) [0x00009] in <01bfddd6944e4ae6baa74476d9774428>:0

art0007i commented 9 months ago

Just ran into the same thing, but on UnlitMaterial. Maybe this issue could be renamed to "setting VertexColorInterpolationSpace to sRGBAlpha stops material from updating".