Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
141 stars 2 forks source link

Issue: Quantity Types Not Accessible and Broken & Crashes Headless / Clients #401

Open Xlinka opened 1 year ago

Xlinka commented 1 year ago

Describe the bug?

As illustrated in the screenshots section, the issue arises when utilizing the time format quantity node, which relies on the <time> input. Currently, we have transitioned to using <DateTime>. When attempting to modify the base value of this component, it reverts back to 0 as the designated field does not exist on the Protoflux node, thus failing to apply any specified value.

As funny as it is to say "Time Does Not Exist" in this scenario.

Moreover, there is a noticeable accessibility challenge with these nodes at the moment. They are not readily visible in the browser, requiring manual input to access:

Elements.Quantity.Time
Elements.Quantity.<QuanityType>

This setup may pose an accessibility hurdle, especially for new users, as it's not very user-friendly.

To Reproduce

Steps to Reproduce

  1. Spawn a Protoflux browser using the Protoflux tool.
  2. Navigate to the Math section, then proceed to Quantity, and select any of the generic arguments available.
  3. Observe that the fields are blank, indicating that the nodes are not easily accessible.
  4. To access a specific node, manual input is required: enter Elements.Quantity.Time into the Type field to select it.
  5. Pull out the Time field and notice that the Value input field is blank.

Expected behavior

The expected behavior is for all the quantity types to be organized under their respective areas, ensuring that none of the fields are left blank or unassigned. This structured arrangement will promote a more user-friendly experience, facilitating easier navigation and manipulation of the nodes, especially for new users.

Also for the value time input type to be fixed or to allow a cast between DateTime and Time or edit the quantity node to accept datetime as a input as a replacement.

Screenshots

Screenshot 2023-10-22 222213 Screenshot 2023-10-22 222724 Screenshot 2023-10-22 223106

Resonite Version Number

2023.10.20.831

What Platforms does this occur on?

Windows

What headset if any do you use?

Desktop, VR

Log Files

Host Log File: TRD-42300 - 2023.10.20.831 - 2023-10-22 12_05_01.log

My Log: XLINKA - 2023.10.20.831 - 2023-10-22 22_47_25.log Crash at 10:55 my time and host 11:55

Additional Context

No response

Reporters

@xlinka . xlinka

Xlinka commented 1 year ago

Adding onto this issue, if the Time ValueInput is left pulled out in a world or is spawned when a user joins and trys to load the ValueInput

https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/22996716/c5c371d8-f21e-4737-8948-082d9b8399c6

shiftyscales commented 1 year ago

Please do not ever exclude the submission of log files, even if you do not believe them to be relevant, or think you know the cause of the issue, @Xlinka. They are required as per our best practices.

Please make and submit a clean replication log from both client and host for this issue.

Xlinka commented 1 year ago

Thank you for bringing this to my attention. I appreciate your feedback, and I apologize for any inconvenience caused. I have now amended the issue to include both log files, as I understand that they may be relevant in resolving the problem.

I submitted the initial issue while I was somewhat sleep-deprived and had intended to update it with the missing log files at a later time as I did not have the host Log Files. I appreciate your understanding regarding this matter.

Frooxius commented 2 months ago

Is this issue still present? We did a lot of changes to headless with the new type system, which should've fixed this.

XDelta commented 2 months ago

Looks like there are multiple issues described and mentioned together which should probably be split up. Just tested and ValueInput<Time> doesn't cause any crashes when spawned out and it does retain its stored value.

stiefeljackal commented 2 months ago

Looks like there are multiple issues described and mentioned together which should probably be split up. Just tested and ValueInput<Time> doesn't cause any crashes when spawned out and it does retain its stored value.

That is what I saw in this Issue as well. As a summary of what was listed in here:

Besides the first bullet, the last two bullets should be split into separate issues.