Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
133 stars 2 forks source link

Enable Hardware Acceleration for VLC Video Decoding #425

Open Enverex opened 10 months ago

Enverex commented 10 months ago

Is your feature request related to a problem? Please describe.

Currently it would seem that video decoding doesn't use hardware acceleration. Not too much of an issue on lower resolution video, but becomes more of a problem on higher resolution video and more intensive codecs. Also given that Resonite seems to be CPU heavy, offloading this from the CPU to dedicated GPU decoders seems like an obvious performance win.

image

Describe the solution you'd like

Video decoding available for VLC playback. Hardware playback DOES work when using Unity, but this then depends on users having third-party codecs installed ahead of time and I've been advised it has other potential quirks when going that route.

If there are concerns over the stability of hardware acceleration, then making it a startup switch (e.g. -hwvid) would allow users that know their hardware isn't problematic to enable it themselves.

Describe alternatives you've considered

As mentioned above, Unity plus native Windows codecs. But this requires third party software to be installed and isn't deemed reliable by the team.

Additional Context

No response

shiftyscales commented 6 months ago

IIRC the reason that hardware acceleration wasn't enabled for our existing video libraries was that it massively lowered stability/greatly increased the likelihood for crashes.

This likely wouldn't get fixed/implemented with the current video libraries and as such is blocked by the eventual VLC upgrade.

shiftyscales commented 6 months ago

@Geenz stood up an issue for the VLC upgrade here: #1476.