Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
140 stars 2 forks source link

PBS_Triplanar ObjectSpace bug #809

Open gameboycjp opened 11 months ago

gameboycjp commented 11 months ago

Describe the bug?

PBS_TriplanarMetallic and PBS_TriplanarSpecular with ObjectSpace turned on has inconsistent behaviour between MeshRenderers and SkinnedMeshRenderers On MeshRenderers, object scale is respected, but on SkinnedMeshRenderers, it is not.

To Reproduce

resrec:///U-gamethecupdog/R-E692A7BF684A3C73C21C1A3359C07D95DAE87DDD1EE13087106DF03CFC28CC46 Normal meshes don't seem to display in SkinnedMeshRenderers and I don't know of any procedural meshes that produce correctly displaying skinned meshes, so I'll just include the object I'm working on.

Expected behavior

ObjectSpace should respect scale on both MeshRenderers and SkinnedMeshRenderers.

Screenshots

https://media.discordapp.net/attachments/1178802968204677272/1178802968544432190/image.png https://www.youtube.com/watch?v=pC6Mu7hFvSs

Resonite Version Number

2023.11.25.49

What Platforms does this occur on?

Windows

What headset if any do you use?

Desktop, Valve Index

Log Files

DESKTOP-3EE2DAL - 2023.11.25.49 - 2023-11-27 13_40_06.log

Additional Context

The Discord thread I started before I nailed the issue.

Reporters

gamethecupdog

Frooxius commented 11 months ago

This might not be a bug, because SkinnedMeshRenderer works differently from the MeshRenderer, so some difference in behavior can be normal.

Or is it both?

gameboycjp commented 11 months ago

There are no bones on these renderers. I'm scaling the entire hierarchy.

Frooxius commented 11 months ago

You need to use bones with SkinnedMeshRenderer for it to work correctly - it's specifically for meshes that are being transformed by bones.

If that's the case, I'll close this as not a bug.

TisFoolish commented 11 months ago

What about meshes that have no bones but have blendshapes?

Frooxius commented 11 months ago

Oh, I forgot about those. Hmm those are a bit of an odd case. Is this what's being used here?

TisFoolish commented 11 months ago

From the discord thread OP linked it looks like it. They posted a screenshot that shows that the mesh has no bones but does have at least one blendshape image

gameboycjp commented 11 months ago

Yes, it is. Thank you Foolish.

Frooxius commented 11 months ago

Thanks, I'll have to investigate this some more.