Fixed Values for Bitrate Quality Slider on AudioStreamSpawner

PointerOffset commented 10 months ago

Is your feature request related to a problem? Please describe.

When trying to set a bitrate for a UserAudioStream the user is presented with a slider with values ranging from 2.5 kbps - 500 kbps. This allows for values like 137.23 kbps. While I'm not sure if this "invalid" in any technical way it is a little atypical and frustrating if you want to set a specific value.

Describe the solution you'd like

In most situations I've observed, audio bitrates are set with a fixed selection of options. This is an example of audio bitrate options taken from OBS-Studio:

An interface that limits bitrate quality options in a similar way may be preferable to the raw float value currently being used. There could be several approaches to changing this. I suspect the least intrusive is probably to setup the slider to have snap points to snap to common values like 64 kbps or 256 kbps.

The minimum and maximum values may warrant adjustments. 2.5 kbps seems too low to be useful and 500 kbps may be higher than anyone would need.

Describe alternatives you've considered

Some other options I've considered:

Allow the user to type in a specific value (this could be clunky and tedious)
Change the slider to an enum or a list of specific values to toggle/page through (may require significant code change)
Drive the index of a ValueMultiplexer<float> using the slider. It would contain a list of bitrate values to select from using the slider. (Not sure if this is "elegant" but I implemented this in a mod)

Additional Context

I wrote a mod which implements the last suggestion on my list of alternatives: https://github.com/PointerOffset/RML-StreamBitrateSelector

PointerOffset commented 7 months ago

Small bump to state this may be appropriate to consider under work for issue https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/584

shiftyscales commented 7 months ago

I'm not sure that I understand how this is related to the settings rework, @PointerOffset?

Drop downs are not implemented in UIX yet, and would have to be before your requested change could be made. They're not a pre-requisite for the settings rework- but are a separate work item. Once drop downs are implemented though, I agree it would make sense to add them to the existing UI wherever it makes sense to.

Frooxius commented 7 months ago

I might end up needing to implement drop downs as part of the Settings UI rework, but no promises at this point.

PointerOffset commented 7 months ago

This isn't necessarily a request for drop-downs in the setting UI. Although that would be appropriate for this feature.

I'm only mentioning this issue because it sounds like UserAudioStream settings need to be touched during the UI rework. So you may want to consider my suggestion if it already needs to be worked on. In one of the devlogs @Frooxius mentions:

This includes stuff like the default audio stream settings, desktop view tab (which used the setting system to remember the last selected screen, opacity and brightness) and notably the interactive/streaming camera, which has a lot of them.

from: https://discord.com/channels/1040316820650991766/1154514014563483759/1210287718526095360

Sorry if I'm misunderstanding the scope of the settings rework. It just seemed appropriate to raise this issue if it's a convenient time to consider it.

Frooxius commented 7 months ago

It does get touched, but this will require adding a new mechanism for this too, so it will depend on whether or not I end up committing to implementing that kind of mechanism.

I'm considering it, in particular because of I might end up doing the drop downs for other things too (enums), but I'm not 100 % sure yet.

Yellow-Dog-Man / Resonite-Issues