Grab World Locomotion moves user forwards by a tiny amount every time

art0007i commented 11 months ago

Describe the bug?

Whenever using the grab world locomotion pushing the thumbstick forward to enter "world grabbing" mode the user is moved forwards ever so slightly. This makes it difficult to use this locomotion to position yourself precisely.

To Reproduce

Use grab world locomotion. Whenever using it you will move forward each time it's activated

Expected behavior

Whenever "world grabbing" mode is activated, it should keep the user in the exact same position, and only after they move their hand they should be moved.

Screenshots

No response

Resonite Version Number

2023.10.13.743

What Platforms does this occur on?

Windows, Linux, Android / Quest

What headset if any do you use?

No response

Log Files

No response

Additional Context

I have created a mod that fixes this issue: https://github.com/art0007i/FixGrabWorld

Reporters

art0007i

shiftyscales commented 11 months ago

Where does the underlying issue lie/what did you change to correct this behaviour in your mod, @art0007i?

Nytra commented 11 months ago

From what I can tell, the mod is changing GrabWorldLocomotion's TryActivate() method to get the global position of the GripReference instead of the DirectionReference

Frooxius commented 11 months ago

I can look at fixing this, which can be quick, but I'd probably just rework the grab mode a bit, to be more flexible and support stuff like rotating, scaling and so on. That way it's a fair bit more flexible locomotion system.

Readun commented 4 months ago

Wouldn't it be good to have the 'small' fix and have the expansion of its features later on be better? (Judging by Nytra's response)

Frooxius commented 4 months ago

It's not about expansion, but wanting to just rewrite it completely, since there's a number of other issues with this mode.

It can be more efficient to deal with things in "bulk" sometimes.

Yellow-Dog-Man / Resonite-Issues