search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
139 stars 2 forks source link

Duplicate protoflux groups maintain connections to original copies #984

Open code807 opened 10 months ago

code807 commented 10 months ago

Describe the bug?

When duplicating selected groups of ProtoFlux nodes, the duplicates maintain connections to the original ProtoFlux.

To Reproduce

Expected behavior

The duplicate nodes should have connections between each other rather than connections to their originals.

Screenshots

Resonite_xMXMkragu4 Resonite_hsW2s7Pb8W Resonite_5yNvX3CgtC

Resonite Version Number

Beta 2023.12.21.1127

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

DESKTOP-1E2V3A8 - 2023.12.21.1127 - 2023-12-23 00_35_53.log

Additional Context

No response

Reporters

code807

Nytra commented 10 months ago

~Possibly related https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/907~

art0007i commented 10 months ago

Possibly related #907

I don't think that issue is related at all. I'm pretty sure this issue happens because when you grab multiple items and duplicate them each one is duplicated individually, rather than all at once

shiftyscales commented 9 months ago

Agreed- #907 is a separate issue.

I don't think this is a bug, however. There are situations in which it makes sense for a duplicated node to point to its original connections- you are duplicating the nodes exactly as they are.

It is already possible to duplicate ProtoFlux in the way you are asking- you would just have to have it packed into a slot, and duplicate that slot instead.

This may be something that would fall under #599 which would unify selection systems in Resonite, and improve multi-select functionality.

JackTheFoxOtter commented 9 months ago

I would definitely consider this a bug. You're holding a group of objects with internal references. Duplicating them should properly re-assign the references in the same way references within duplicated hierarchies are reassigned everywhere else in Resonite.

It is also currently impossible to hold a group of ProtoFlux and bring it with you into a different world by focusing there without the node connections breaking, I assume for the same underlying issue this ticket is describing.