search

Yellowen / Faalis

A RubyOnRails platform for rapid web application development. Containing a rich and flexible dashboard interface
GNU General Public License v2.0
54 stars 15 forks source link

Using outdated foundation-rails gem #1

Closed arashm closed 9 years ago

arashm commented 10 years ago

You haven't specified the needed version of foundation-rails in your gemspec, so in applications the newest version will be used. This causes some problems while you're using older Foundation in your Engine.

In newer version foundation-global file is removed and you should only import foundation instead.

There are other issues like I guess there is a change in button-size mixin, which in the new version it only gets 2 arguments not 3.

lxsameer commented 10 years ago

I see, Migration process is not completed yet, We can't test the new environment because of some technical difficulties in our host project. But we will do it ASAP.

Thanks for your review

lxsameer commented 10 years ago

I updated Faalis to use zurb-foundation 5 please check it out and let me know if there is any problem.

Thanks ;)