Yelp / MOE

A global, black box optimization engine for real world metric optimization.
Other
1.31k stars 139 forks source link

[Python] stop instantiating colander schemas at every use site #337

Open suntzu86 opened 10 years ago

suntzu86 commented 10 years ago

From my comment on #291

lots of colander examples appear to instantiate schemas immediately after definition so that they're only instantiated once. We do a mix of A) instantiate as class variable or B) instantiate at use site. It'd be good to establish what standard colander style is and follow that. The choice here could be relevant to issue #336 b/c it may expose more instances of that problem.