search

Yelp / MOE

A global, black box optimization engine for real world metric optimization.
Other
1.31k stars 139 forks source link

Fix bandit bugs and add new tests #387

Closed sc932 closed 10 years ago

sc932 commented 10 years ago

Sample arm has the following methods that do not work

  1. __add__, always returns None, so A + B = None for any A or B
  2. __str__ throws an exception, we call _asdict but subclass object instead of namedtuple, so this method does not exist

We should fix these up (one line each) and add tests.

p0.5 Broken code in production.

suntzu86 commented 10 years ago

It's worth double-checking other __str__, etc. overrides to make sure that they produce the expected results.