Yelp / MOE

A global, black box optimization engine for real world metric optimization.
Other
1.31k stars 139 forks source link

Add Bandits to moe examples #393

Closed norases closed 10 years ago

norases commented 10 years ago

***** PEOPLE ***** Primary reviewer: @sc932

Reviewers: @suntzu86

***** DESCRIPTION ** Branch Name: norases_386_add_bandits_to_moe_examples Ticket(s)/Issue(s): #386

***** TESTING DONE ***** make test make style-test

sc932 commented 10 years ago

:boat: this!

suntzu86 commented 10 years ago

couple of comments, mostly looks fine to me. i'll let @sc932 judge the actual example code b/c he's had more experience building those

suntzu86 commented 10 years ago

@sc932 also is it worth giving in any description of what the expected results should look like and why? i know we don't do this for the other examples (yet) but that could be helpful

norases commented 10 years ago

The expected results are explained in comments for arm_allocations.

suntzu86 commented 10 years ago

maybe add in some links then? for someone who's reading this file & moe the first time, idk if it's clear where to go and look for more info about bandits since the actual bandit policy descriptions are hidden behind a bunch of REST stuff

suntzu86 commented 10 years ago

o/w shipit from me

norases commented 10 years ago

Thanks @suntzu86 ! Already had links in the code. Added See :doc:bandit for more details on multi-armed bandits in the header of bot bandit_example and bandit_simple_endpoint.

suntzu86 commented 10 years ago

perfect! shipit