search

Yelp / MOE

A global, black box optimization engine for real world metric optimization.
Other
1.31k stars 139 forks source link

optimizer param struct improvements #425

Closed suntzu86 closed 9 years ago

suntzu86 commented 9 years ago

***** PEOPLE ***** Primary reviewer: @sc932

Reviewers:

***** DESCRIPTION ** Branch Name: eliu_gh_138_expose_cpp_struct_data_members_to_python Ticket(s)/Issue(s): Closes #138 Closes #391

meat of change in: moe/optimal_learning/cpp/gpp_optimizer_parameters.hpp moe/optimal_learning/cpp/gpp_python_common.cpp moe/optimal_learning/python/comparison.py moe/optimal_learning/python/cpp_wrappers/optimization.py moe/tests/optimal_learning/python/comparison_test.py moe/tests/optimal_learning/python/cpp_wrappers/optimization_test.py

C++ optimizer param structs now direclty readable/writeable from Python C++ GradientDescentParameters now tracks num_steps_averaged (but doesnt use it)

***** TESTING DONE ***** make test manual checking

sc932 commented 9 years ago

Looks good, some quick questions in the tests, I'm happy to :sheep: though.