search

Yelp / MOE

A global, black box optimization engine for real world metric optimization.
Other
1.3k stars 139 forks source link

Mw/pip fixed #456

Closed KukumavMozolo closed 8 years ago

KukumavMozolo commented 8 years ago

Fix for issue: https://github.com/Yelp/MOE/issues/455

suntzu86 commented 8 years ago

Thanks for finding & fixing these! A few small comments for you. I'll merge if you could make the adjustments.

Also, the automated testing log shows a bunch of import errors around the tests and other weird looking failures: https://s3.amazonaws.com/archive.travis-ci.org/jobs/121683951/log.txt ==================== 62 passed, 24 error in 100.68 seconds ===================== Do the tests run for you locally (i.e., can you build the dockerfile (which runs make test); have you run make style-test on your changes?

Admittedly I haven't been tracking the docker & web stuff as much b/c I don't use them. Bad on me :(

KukumavMozolo commented 8 years ago

I made the changes you suggested. sudo docker build -t moe_container . runs fine locally. Do the import errors only arise for my request? Maybe outdated pip in travis?

suntzu86 commented 8 years ago

I honestly have no idea... nothing in your change should have caused those things to break, and the tests were passing as of the last real MOE commit (ages ago).

I'm not going to worry about it for your change, lol. I'll add a comment to the docs to indicate something is broken in packaging or our travis usage.

Thanks for updating!