Server timeout is not updated every time a POST to results happens

Yelp / Testify

A more pythonic testing framework.

Other

308 stars 67 forks source link

Server timeout is not updated every time a POST to results happens #110

Closed EvanKrall closed 11 years ago

EvanKrall commented 12 years ago

This causes an interesting race condition where you can have a class that takes more than the --server-timeout total, but less than --runner-timeout in between results -- if no other clients are finishing classes or checking out classes in the mean time, the server timeout doesn't get updated and the server can bail with 'No client activity for %ss, shutting down.'

I think the fix is just to put a call to self.activity() in TestRunnerServer.report_result.

EvanKrall commented 11 years ago

We just ran into this again. I'll make a branch.

mrtyler commented 11 years ago

Fixed in https://github.com/Yelp/Testify/pull/171.