violation collector: make read fd non-blocking and check for event type when polling

Yelp / Testify

A more pythonic testing framework.

Other

308 stars 67 forks source link

violation collector: make read fd non-blocking and check for event type when polling #139

Closed baris closed 11 years ago

baris commented 11 years ago

Fixes some of the issues on buildbot. Using a non-blocking fd with edge triggered flag is already suggested in epoll man page (http://linux.die.net/man/4/epoll), apparently I've forgot about that before.

mrtyler commented 11 years ago

ShipIt.

Although I would expect either a new test or a modification to an existing test to test the slightly-modified behavior.

baris commented 11 years ago

The last change fixes another issue with the plugin. From commit log:

"ViolationStore used to connect to the database before the process is forked and executed in catbox, so connection objects got duplicated. Two process try to use the same connection to update the database and mysql client library does not like it at all."

mrtyler commented 11 years ago

New tests look good. I proposed offline some places to add comments.

ShipIt!