Closed creason closed 10 years ago
I dont' see any tests?
Yeah, hence "I didn't write any tests, but I can if y'all think this is worth pulling into Testify." This is sort of a proof-of-concept (it really should support multiple targets for one); I wanted to see if y'all thought the idea was worth incorporating before spending more time on it.
If so, let me know and I'll add multiple targets and tests.
Yes, sorry, I missed that.
I don't have a strong opinion on the value of this experiment, but I'm opposed to adding code to master unless it is covered by tests. Perhaps you could experiment with a branch locally to see how this works in practice if you're afraid of "wasting" effort on tests?
We can't merge this without tests.
Also, I think a better approach to this problem would be generating cprofile data for every test. This would build a database which can list all related functions for any test, and vice versa, as well as providing potentially-valuable timing information.
Thirdly, we're trying to feature freeze testify with an aim to move to pytest.
Cool (I had actually meant to drop this request earlier but I guess I let it slip).
FWIW: I agree about using something like cprofile, though you'd have to chase links recursively. I'm a fan of the move to pytest (this was written a while back). Re: tests, as above I wrote this quickly and wanted feedback on the value before spending more time on tests.
Hopefully this should be self-explanatory. I didn't write any tests, but I can if y'all think this is worth pulling into Testify.