Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

fix test filtering regression in more-fair-bucketing #226

Closed bukzor closed 10 years ago

bukzor commented 10 years ago

The recent more-fair-bucketing branch caused testify to no longer filter test cases when requested. This fixes it.

milki commented 10 years ago

Nice catch. lgtm, We should probably have a regression test for this.

bukzor commented 10 years ago

Clean travis: https://travis-ci.org/bukzor/Testify/builds/17859810

I'm asking @asottile to write one, but imo this could merge before that.

asottile commented 10 years ago

Admittedly I'm not sure I know enough as to what was the broken behaviour or what this fixed. I think I need a tiny bit more context... but yeah if I broke something, it'd be great to fix it :D