search

Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

the testify clients' exit codes are backward #239

Closed bukzor closed 10 years ago

bukzor commented 10 years ago

Testify clients currently exit 1 on success, 0 on failure, which is the opposite of the correct situation.

EvanKrall commented 10 years ago

that's amazing

asottile commented 10 years ago

I fixed this with #235

bukzor commented 10 years ago

Ah I've titled this wrong. The actual problem is the exit code is 1 if the WARNING Got error URLError(error(111, 'Connection refused'),) when requesting tests, retrying 95 more times. case is ever encountered, regardless of how many tests pass.

I'd consider a testify client to be successfull if it runs all the tests it was supposed to, regardless of the count of failures. You?

bukzor commented 10 years ago

asottile fixed this. We just don't have it installed yet.