Closed rambleraptor closed 10 years ago
Additionally, I wrote some documentation for building new Testify plugins and put it up on the internal wiki. Is there any interest in placing that on Github?
If its minimal work, we do have the wiki page for this repo that might be a good place to put documentation on.
Flake8 was added on the makefile but isn't on the Travis CI server. How can I add it or should we wait off?
.travis.yml contains essentially a bash script. Look at it. It's designed to be simple.
I'd probably put the quality control procedures somewhere central, either in the Makefile or a bash script, then invoke it both places, to ensure that the two use cases don't drift away from each other.
@astephen2 You've correctly edited the CI process, but it fails because not all flake8 issues are resolved.
Your choices are:
In any case, CI needs to finish successfully.
For the time being, I've removed the flake8 dependency. I feel like there should be a discussion about how to handle codes style in Testify before automated style checking is added in.
I see you've found a fourth option :P I'll leave the rest to milki.
lgtm. Thanks.
This pull request adds in a plugin to annotate TestCases with a list of all of the methods within that are Unit Tests. Additionally, a new testify plugin hook was created to help do this.