search

Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

Style Changes #242

Closed rambleraptor closed 10 years ago

rambleraptor commented 10 years ago

Made some PEP8 changes per milki

asottile commented 10 years ago

I'd rather we stick to this calling format:

my_really_long_function_name(
    'need',
    'line',
    'continuation',
    blah='blah',
)

imo it's much easier to parse (and type since you don't need to spend so much time indenting to an odd number of spaces) when reading code than:

my_really_long_function_name('need',
                             'line',
                             'continuation',
                              blah='blah',)

(I had to rewrite the second one 5 times to get them to line up)

The top style also aligns with Yelp's styleguide ( PythonStyleGuidelines#Multi-lineMethodInvocationsargumentindentation )

There also appears to be an unrelated commit to "style changes".

Also it'd be awesome if you added flake8 to our build if you're going to make it compliant (otherwise we'll just regress).

ymilki commented 10 years ago

To be clear on what happened,

This request was supposed to be an update to #241. @asottile's comments still apply to #241.

rambleraptor commented 10 years ago

I'm not sure if @asottile will get this on the correct branch, but I'll add in flake8 on the Makefile. I have the feeling that parts of Testify (especially the plugins) will be less than pleasant.