search

Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

changed all unix-only dependencies #245

Closed jareyes409 closed 10 years ago

jareyes409 commented 10 years ago

There were several locations with unix-only dependencies. These were causing errors when running in a windows console. Wrapped all of these with try logic. Now it all runs in windows without any errors.

bukzor commented 10 years ago

LGTM: waiting for shipit from @ymilki or @asottile

May or may not be obvious: since windows is not part of our CI process, it's going to be hard to guarantee that this doesn't regress.

ymilki commented 10 years ago

I'm not familiar with windows programming at all. I'm fine with this as long as the test suite continues to pass. As @bukzor, we don't have windows in our CI though, so we won't be validating these changes or following regressions.

asottile commented 10 years ago

Looks good to me, would love if we could get rid of the line that says buildbot because wat.