search

Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

Flakey race condition in test_runner_server_test #253

Closed asottile closed 9 years ago

asottile commented 10 years ago

This appears to be flakey:

yes | xargs --replace testify test.test_runner_server_test TestRunnerServerTestCase.test_fail_then_timeout_twice

The race appears to be on this line:

https://github.com/Yelp/Testify/blob/0fda7b0f332983486fd6d6dc4ae6ef10306bb39f/test/test_runner_server_test.py#L42

^ That function should also probably use Queue.Queue instead of threading.Semaphore

Probably caused by the nonblocking behaviour on this line:

https://github.com/Yelp/Testify/blob/0fda7b0f332983486fd6d6dc4ae6ef10306bb39f/testify/test_runner_server.py#L165

asottile commented 9 years ago

cannot reproduce