search

Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

Bugfixes for my last PR #260

Closed rambleraptor closed 10 years ago

rambleraptor commented 10 years ago

I made a fix to my last PR (INFRA-1346). This should stop the messages from appearing for unittest_annotation.

bukzor commented 10 years ago

This looks like three attempts to fix one thing. I'd squash them. Not a big deal tho.

bukzor commented 10 years ago

Except: pass is a smell.

This plugin should only be active when the user has opted into catbox. If they have asked for cat box, and you can't connect to the catbox db, this plugin should fail early and loudly. The obvious way to implement that behavior is to remove this try/except statement entirely.

The core issue is that this plugin is unconditionally active. The fix includes only activating it when catbox is requested.

ymilki commented 10 years ago

I'm fine with this fix as long as we open a new issue to make this annotation conditional.

rambleraptor commented 10 years ago

I'll create the issue and start working on it now.