Closed rambleraptor closed 10 years ago
This looks like three attempts to fix one thing. I'd squash them. Not a big deal tho.
Except: pass is a smell.
This plugin should only be active when the user has opted into catbox. If they have asked for cat box, and you can't connect to the catbox db, this plugin should fail early and loudly. The obvious way to implement that behavior is to remove this try/except statement entirely.
The core issue is that this plugin is unconditionally active. The fix includes only activating it when catbox is requested.
I'm fine with this fix as long as we open a new issue to make this annotation conditional.
I'll create the issue and start working on it now.
I made a fix to my last PR (INFRA-1346). This should stop the messages from appearing for unittest_annotation.