search

Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

Fix #240 moar. #274

Closed asottile closed 10 years ago

asottile commented 10 years ago

Verified via:

yes | head -n 50 | xargs --replace testify test/test_program_test.py Test240Regression -v

asottile commented 10 years ago

@ymilki @bukzor

bukzor commented 10 years ago

travis' error went away on retry

bukzor commented 10 years ago

can we get some explaination of the changes?

asottile commented 10 years ago

1 worker + tests in the queue = it won't consider that test a valid test because pair_queue is not empty

The original conditional reads something like

if the worker this failed on is not us or this is the last test and I am the only worker:

the new conditional reads

if the worker this failed on is not us or i am the only worker

bukzor commented 10 years ago

Right, that's bogus. I forgot that pair_queue.empty meant no tests. I'm not sure it should really have those methods; I'm pretty sure it shouldn't.