search

Yelp / Testify

A more pythonic testing framework.
Other
306 stars 67 forks source link

Fix unittest annotate #287

Closed baris closed 9 years ago

baris commented 10 years ago

This plug-in (apparently) depends heavily on violations collector plug-in. Let's just make it use violation collector's configuration and add an option to enable/disable this plugin.

asottile commented 10 years ago

travis is failing :(

darioush commented 10 years ago

https://github.com/baris/Testify/blob/master/test/plugins/unittest_annotate_test.py#L9 needs to be updated too. Should fix travis

baris commented 10 years ago

I shouldn't have created the PR earlier. Sorry! I merged in my test fix branch too.

baris commented 10 years ago

That being said I'm not really happy with this plugin. This branch will fix the failure in the nightly builds, though. So, I'd like it to get merged.

imbstack commented 9 years ago

+1 from me. @ymilki can help us deploy this soon