Yelp / Testify

A more pythonic testing framework.
Other
304 stars 67 forks source link

Give testify a new version #312

Closed ealter closed 9 years ago

ealter commented 9 years ago

After #293, let's give testify a new version so that we can integrate this change into yelp's codebase.

bukzor commented 9 years ago

I wanted to do some work on suite discovery before we go through the pain of a rollout.

I'll try to get to it soon.

--phone is hard. On Apr 30, 2015 3:56 PM, "Eliot Alter" notifications@github.com wrote:

After #293 https://github.com/Yelp/Testify/pull/293, let's give testify a new version so that we can integrate this change into yelp's codebase.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312.

asottile commented 9 years ago

We've stopped doing expensive rollout with 0.6.0 at yelp (we've stopped bumping the system version). I think release is not a big deal since it's all virtualenv 'd

Phone is also hard On Apr 30, 2015 9:40 PM, "Buck Evan" notifications@github.com wrote:

I wanted to do some work on suite discovery before we go through the pain of a rollout.

I'll try to get to it soon.

--phone is hard. On Apr 30, 2015 3:56 PM, "Eliot Alter" notifications@github.com wrote:

After #293 https://github.com/Yelp/Testify/pull/293, let's give testify a new version so that we can integrate this change into yelp's codebase.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312#issuecomment-98042814.

ealter commented 9 years ago

The reason I want to give this a version number is so that I can make yelp-main compatible with testify-master (since the most recent change is not backwards compatible).

I'd like to get started on my work with factories, but I can't do that until testify has the addfinalizer function (assuming that my pull request is approved). I can't add that function until yelp-main is compatible with the current master of Testify. On Apr 30, 2015 9:42 PM, "Anthony Sottile" notifications@github.com wrote:

We've stopped doing expensive rollout with 0.6.0 at yelp (we've stopped bumping the system version). I think release is not a big deal since it's all virtualenv 'd

Phone is also hard On Apr 30, 2015 9:40 PM, "Buck Evan" notifications@github.com wrote:

I wanted to do some work on suite discovery before we go through the pain of a rollout.

I'll try to get to it soon.

--phone is hard. On Apr 30, 2015 3:56 PM, "Eliot Alter" notifications@github.com wrote:

After #293 https://github.com/Yelp/Testify/pull/293, let's give testify a new version so that we can integrate this change into yelp's codebase.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312#issuecomment-98042814.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312#issuecomment-98044004.

bukzor commented 9 years ago

Ah, true. In that case, disregard my comment and go for it.

--phone is hard. On Apr 30, 2015 9:42 PM, "Anthony Sottile" notifications@github.com wrote:

We've stopped doing expensive rollout with 0.6.0 at yelp (we've stopped bumping the system version). I think release is not a big deal since it's all virtualenv 'd

Phone is also hard On Apr 30, 2015 9:40 PM, "Buck Evan" notifications@github.com wrote:

I wanted to do some work on suite discovery before we go through the pain of a rollout.

I'll try to get to it soon.

--phone is hard. On Apr 30, 2015 3:56 PM, "Eliot Alter" notifications@github.com wrote:

After #293 https://github.com/Yelp/Testify/pull/293, let's give testify a new version so that we can integrate this change into yelp's codebase.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312#issuecomment-98042814.

— Reply to this email directly or view it on GitHub https://github.com/Yelp/Testify/issues/312#issuecomment-98044004.

asottile commented 9 years ago

313