search

Yelp / Testify

A more pythonic testing framework.
Other
307 stars 67 forks source link

This is v0.11.0 #337

Closed bukzor closed 8 years ago

asottile commented 8 years ago

The last change was barely a bugfix, 0.11.0 implies breaking probably

asottile commented 8 years ago

Also way to wait before merging :(

bukzor commented 8 years ago

All bumps during v0 are major, imply backwards incompatibility.

On Tue, Aug 2, 2016 at 5:15 PM, Anthony Sottile notifications@github.com wrote:

Also way to wait before merging :(

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Yelp/Testify/pull/337#issuecomment-237090637, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnFSAO1PGDUwVVi_mXkQglay1N6Xm0qks5qb92JgaJpZM4JbLQn .

asottile commented 8 years ago

There is no backwards incompatibility here. 0.10.1 would have been a more appropriate version

bukzor commented 8 years ago

They're equally inappropriate; all bumps before v1 are major.

On Tue, Aug 2, 2016 at 5:17 PM, Anthony Sottile notifications@github.com wrote:

There is no backwards incompatibility here. 0.10.1 would have been a more appropriate version

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Yelp/Testify/pull/337#issuecomment-237091073, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnFSP8sVKQKN1qZ5ubgJYIvdt87oHTBks5qb94VgaJpZM4JbLQn .

asottile commented 8 years ago

I disagree. But it's too late now you already merged without waiting for feedback

bukzor commented 8 years ago

It's not a matter of opinion. http://semver.org/

On Tue, Aug 2, 2016 at 5:23 PM, Anthony Sottile notifications@github.com wrote:

I disagree. But it's too late now you already merged without waiting for feedback

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Yelp/Testify/pull/337#issuecomment-237092143, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnFSNWfixWwXESGtM-IEsBckpoSmEYUks5qb99kgaJpZM4JbLQn .

asottile commented 8 years ago

semver does not define what to do less than 1.0.0, only that semantic versioning begins at 1.0.0. In my opinion, the most sensible thing to do is denote non-breaking changes less than version 1 by changing the patch version. You may not agree with me, but I think that is the most reasonable thing to do. I think if you surveyed people, they'd generally agree with that.