Yelp / bravado-core

Other
109 stars 98 forks source link

Update test_validate_invalid_polymorphic_does_not_alter_validation_paths assertion #309

Closed macisamuele closed 5 years ago

macisamuele commented 5 years ago

The assertion seems to break our internal tests.

>       assert validation_error.message == '\'birth_date\' is a required property'
E       assert "u'birth_date...ired property" == "'birth_date' ...ired property"

This is most likely caused by the usual unicode issue :(

I do see two potential approaches there:

I wanted to try the first approach but it ends up taking a bit longer as a few tests need to be fixed (issue similar to the above snipped), so I'm relaxing the condition first so we could get internal tests green again

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 98.333% when pulling 7bf317eee22997ec7450bc75a54ec85469ce5e26 on macisamuele:maci-update-broken-test into cde813a6b89e2cf8322e0ad737f294955a512bad on Yelp:master.

macisamuele commented 5 years ago

Replaced by #316