The objective of this PR is to remove bravado-core dependency on jsonschema.compact.urlopen as it is breaking python 2.7 tests.
The breaking change has been introduced by jsonschema>=3.0.0, specifically on https://github.com/Julian/jsonschema/pull/472/files which alters the behaviour of jsonschema.compact.urlopen on python2.
The alteration consist of wrapping the result of urlopen into a closing which leads to closing an object that does not have close attribute and consequently making the tests failures.
Starting from bravado-core>=5.10.0 we should be supporting jsonschema>=3.0.0 but this specific change was not announced on the CHANGELOG even if it was changing a public interface
Once this PR is approved we should be releasing a new version making explicit the fact that this is the first version that properly works with jsonschema>=3.0.0
Coverage decreased (-0.002%) to 98.456% when pulling 441265faa7108a9b35ac55fc6c0a818303e52b41 on macisamuele:maci-issue-318 into 18e35749893c772948df980cde42cdb90e329f80 on Yelp:master.
The objective of this PR is to remove bravado-core dependency on
jsonschema.compact.urlopen
as it is breaking python 2.7 tests.The breaking change has been introduced by
jsonschema>=3.0.0
, specifically on https://github.com/Julian/jsonschema/pull/472/files which alters the behaviour ofjsonschema.compact.urlopen
on python2. The alteration consist of wrapping the result ofurlopen
into aclosing
which leads to closing an object that does not haveclose
attribute and consequently making the tests failures.Starting from
bravado-core>=5.10.0
we should be supportingjsonschema>=3.0.0
but this specific change was not announced on the CHANGELOG even if it was changing a public interfaceOnce this PR is approved we should be releasing a new version making explicit the fact that this is the first version that properly works with
jsonschema>=3.0.0