Fix Python 3.8 issue, use separate flake8 pre-commit hook, fix tests

Yelp / bravado-core

Other

109 stars 98 forks source link

Fix Python 3.8 issue, use separate flake8 pre-commit hook, fix tests #320

Closed sjaensch closed 5 years ago

sjaensch commented 5 years ago

Starting with Python 3.8 it's not possible to import Mapping from collections, we'll need to use collections.abc as package.

Additionally, I'm introducing the separate flake8 pre-commit hook as well as changing things around pre-commit hook installation slightly to make sure running tox directly also installs them. I've also incorporated the fix from #319 with one slight modification so the tests pass on Python 3.

coveralls commented 5 years ago

Coverage decreased (-0.1%) to 98.335% when pulling b9b22c3c3def3ae93ab689a23bf82fcc8b9e6101 on sjaensch:python38-pre-commit-fix-build into 18e35749893c772948df980cde42cdb90e329f80 on Yelp:master.