search

Yelp / bravado-core

Other
109 stars 98 forks source link

[style] Add `add-trailing-comma` pre-commit hook and bump all pre-commits #332

Closed macisamuele closed 5 years ago

macisamuele commented 5 years ago

The goal of this PR is mostly style related.

I've added add-trailing-comma pre-commit hook, bumped all the hooks and manually addressed few parts were style looked odd.

In the last commit of this PR I've noticed that in the validation flow there were and conditions that might get benefit from inverting the order (as the second condition should be way faster to evaluate). The change does not change any logic but might improve execution time.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 98.313% when pulling 44656e2e147953a0cb2e8d5276a146759b0cc261 on macisamuele:maci-bump-pre-commits-and-add-trailing-comma into 170ea85d1fbea14458388addef6e8d44aaaac71b on Yelp:master.