search

Yelp / bravado-core

Other
109 stars 98 forks source link

Ensure that unmarshal uses the format only if defined #340

Closed macisamuele closed 5 years ago

macisamuele commented 5 years ago

Changes in the unmarshaling logic (PR #336) revealed a new bug being introduced while working with primitive types, which uses a format that is unknown to bravado-core.

This was observed while trying to integrate the library into an internal service.

The goal of this PR is to address the issue and to create a dedicated test that would help to catch this type of error in the future.

If you run the test on the original codebase (current Yelp/master) the test would fail, but running it with the changes in bravado_core/unmarshal.py proposed by this PR the test would be green.

NOTE: This approach is already used in the marshaling flow (PR #339)

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 97.886% when pulling ef7ecf4e73eb8f342a412cd50c3e0883dc4a67ea on macisamuele:maci-unmarshal-should-not-assume-format-presence into 665ca96a5cef81265132ebd0fad09112b0a2f081 on Yelp:master.