Yelp / bravado-core

Other
109 stars 98 forks source link

Enhance equality checks #371

Closed macisamuele closed 4 years ago

macisamuele commented 4 years ago

While working on a branch related to #370 I've noticed that the implemented equality checks are good but not enough ;)

Currently the checks are making some assumptions on the state of certain attributes:

The goal of this PR is to address those issues (still the checks are not perfect, but they should be more accurate) as well as providing a sort of method documentation.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.5%) to 99.006% when pulling 7701eb2cfabff681c21d38222bf15bb0e6d368dd on macisamuele:maci-enhance-equality-checks into 768479985a6d76b85c3649c24c7bb1ccc4dce74c on Yelp:master.