search

Yelp / bravado-core

Other
109 stars 98 forks source link

jsonschema processing doesn't support jsonschema>=4.0.0 causing bravado to break when working in offline environment #388

Open HubertJaworski opened 2 years ago

HubertJaworski commented 2 years ago

When running an installation on clean python environment, Bravado gets installed with the newest jsonschema, currently >=4.0.0

jsonschema 4.0.0 introduced support for newer draft versions, which does not follow the previous pattern of http://json-schema.org/draft-\d+/schema and with values like http://json-schema.org/draft-2019-09/schema

In bravado_core/model.py:883 your regexp for excluding jsonschema's default schemas should be changed to 'http://json-schema.org/draft-\d+(-\d+)?/schema'

Currently, when using bravado in offline environments, attempting to make request fails and crashes the program

GuySuday commented 2 years ago

I, too, encountered this problem

joern-m-h commented 2 years ago

I have the same problem. I opened a PR for it: https://github.com/Yelp/bravado-core/pull/389