Yelp / detect-secrets-server

Apache License 2.0
108 stars 34 forks source link

Feature Extract pragmas #68

Open francisluz opened 4 years ago

francisluz commented 4 years ago

🗒️ Description As a detect-secrets-server user, I would like to extract all pragmas in my codebase where I can validate the use of pragma: allowlist secrets.

💡 Solution Using the current process that loop through the code and plugin, one more step was added to extract the pragmas. This is an optional feature where on the server side will be triggered through a new flag called --extract-pragmas.

⌛ Time complexity The performance impact on the scan if this feature is enabled, will be O(n+1) where extract-pragmas is considered an extra plugin run.

🔴 Unit Test There are unit tests failing that I didn't manage to fix yet, as it was there already.

😎 Hope you guys like this feature, we're already using it in our internal CI process. 👍 Feel free to reach me out.