search

Yelp / firefly

Firefly is a web application aimed at powerful, flexible time series graphing for web developers.
ISC License
172 stars 44 forks source link

Allow graphs with metrics from multiple data servers and data sources #7

Open bigo opened 12 years ago

bigo commented 12 years ago

Back when Firefly was using RRDgraph on the backend to generate graphs, it wasn't feasible to combine data from multiple data centers or even from multiple data sources into one graph. Now that everything's graphed on the front-end, the limitation is more arbitrary and this would be a great feature to enable. I believe that Graph objects are more or less linked to a single data center, so we'll have to fix that as part of this.

Roguelazer commented 11 years ago

This would definitely be awesome...

fhats commented 11 years ago

working on this now

fhats commented 11 years ago

For my reference, the line preventing graphs with two different data sources from the same data server is in stat_monster_rrd.py:

src_file_basename, ds_name = src[-1].rsplit('_', 1)

I think stat_monster_rrd.py is being fed all of the incoming data, and I don't think we have any ganglia stats that won't throw an exception on this line. I think the solution here is being smarter about which data sources get fed which sources to get stats for.

bigo commented 11 years ago

I can look at this on Sunday too.

On Wednesday, March 27, 2013, Fred Hatfull wrote:

For my reference, the line preventing graphs with two different data sources from the same data server is in stat_monster_rrd.py:

src_file_basename, dsname = src[-1].rsplit('', 1)

I think stat_monster_rrd.py is being fed all of the incoming data, and I don't think we have any ganglia stats that won't throw an exception on this line. I think the solution here is being smarter about which data sources get fed which sources to get stats for.

— Reply to this email directly or view it on GitHubhttps://github.com/Yelp/firefly/issues/7#issuecomment-15570174 .

fhats commented 11 years ago

I have a branch in-flight at fhats/7_multi_ds if you want to check it out. I'm hoping to have something ready for review by the weekend