Yelp / kafka-utils

Apache License 2.0
313 stars 127 forks source link

Fix gh acceptance build #271

Closed lsterk closed 3 years ago

lsterk commented 3 years ago

The only problems happened in our acceptance test suite, where we run everything from Docker containers. The main issue happened with how we were setting up our testing suite's virtual environment (in docker/test/Dockerfile) but I also took this chance to migrate to Ubuntu Bionic (18.04) and clean up some other sub-optimal things in our Dockerfiles.

Note that the GH action change is meant to reduce duplicate test runs when creating/updating a CR (see #270) and also ensure that all 3 test suites can run independently - so you still get test results for all 3 even if one fails.

This doesn't change the actual package we distribute, just how we test it.