Fix build failing because of dependencies conflict

Yelp / kafka-utils

Apache License 2.0

313 stars 127 forks source link

Fix build failing because of dependencies conflict #279

Closed amribr closed 2 years ago

amribr commented 2 years ago

Changes:

Updated ipdb and ipython as they failed to install because of incompatibility issues with setuptools==58.3.0
Pinned PyYAML in requirements-dev.txt as PyYAML==6.0 is not compatible with pre-commit==0.8.0 and docker-compose==1.7.0

JayH5 commented 2 years ago

I'm a bit confused as to why this build passed? https://github.com/Yelp/kafka-utils/pull/273

amribr commented 2 years ago

@JayH5 It's probably because we don't install docker-compose or pre-commit except in the testenv via tox and requirement-dev. At this step, PyYAML(6.0) get installed by pre-commit (nested dependency), which actually breaks pre-commit and cause explicit dependency conflict when tox tries installing docker-compose.