search

Yelp / lemon-reset

Consistent, cross-browser React DOM tags, powered by CSS Modules. 🍋
MIT License
131 stars 13 forks source link

Consider adding <Br /> #95

Closed rishabh-ink closed 4 years ago

rishabh-ink commented 4 years ago

I see that the Line-break element (<br />) tag is missing in lemon-reset. Was this just missed out or did we choose not to add it? 🤔

theresama commented 4 years ago

We chose not to add it because it's not part of meyer reset - there are no resets for it. Is there a reason you need it?

rishabh-ink commented 4 years ago

Okay! I was thinking of using it to break a sentence into two lines. But now I see that the same can be achieved using the <Text> component without the paragraph attribute...

<Text>123 Some St.</Text>
<Text>Some Town</Text>

So I guess it’s not really required. I’ll close this issue. Thanks!