search

Yelp / love

A system to share your appreciation
MIT License
142 stars 36 forks source link

Allow users to mark love as "Secret" post-send #22

Open rockdog opened 7 years ago

rockdog commented 7 years ago

On the "My Love" (/me) page, add a "Make secret" link to the right of the timestamp in both the "Sent" and "Received" columns. Style the link in gray so that it doesn't stick out too boldly.

yelp_love_make_secret

Clicking the link will mark the love as secret, and change the link to "Make public". User can toggle back and forth at will.

Also, the leaderboard should only count public love, not private love. It might already work this way, but if it doesn't, we should change it.

brenns10 commented 7 years ago

The leaderboard currently counts both public and private love (noticed a few days back during testing).

Love the idea about being able to toggle secret/public. What would the behavior be for webhooks? Currently webhooks are skipped for secret love. Would we send a webhook event the first time a love becomes public? Every time it becomes public? Or only if it is public when initially sent?

Finally, my two cents about counting private love in the leaderboard. My impression has always been that secret love exists so that you can send a more private or personal message that you don't think is for public eyes. I never really thought that secret love existed to "hide" the fact that person A sent love to person B. So to me it seems weird to remove that love from the leaderboard count, simply because the message wasn't something person A thought the whole world should read. But that's just my opinion, for whatever it's worth :man_shrugging:.

brenns10 commented 7 years ago

I suppose an important consequence of the webhook question is that, if love is sent as public and then made secret, the webhook will still have been sent. Depending on how that webhook is used (e.g. dumping a love into IRC/Slack, which I'm currently doing), marking it as secret will not change the fact that a webhook was sent.

rockdog commented 7 years ago

I would keep the current webhook behavior since the idea behind the current webhook for loves is the notification when a love is created, not updated - so when its created and public the webhook is fired, when love is created as secret the webhook is skipped.

Also I‘d vote for counting secret love in the leaderboard like it is right now.

I migrated this feature request from our internal ticket system. I will ask the initial author for his reasoning.