search

Yelp / love

A system to share your appreciation
MIT License
142 stars 36 forks source link

Add office filter #66

Closed ebrahim-elgaml closed 3 years ago

ebrahim-elgaml commented 5 years ago

Add option to filter leaderboard by office Enhance department search by adding index to department Remove static departments yml file and get the unique departments instead from employees

Verification

Screenshot 2020-11-18 at 14 05 38

Screenshot 2020-11-18 at 14 05 47

Screenshot 2020-11-18 at 14 05 53

Interactive console

ebrahim-elgaml commented 3 years ago

Changes look good to me. I just have a few questions and suggestions:

Departments and Offices seems to be something that one might want to opt in to so could we make these changes such that YelpLove doesn't require the concept of offices and departments?

Would you mind adding a few screenshots of these changes?

I agree with you about making department and office optional the world is moving in the direction of remote work but I would prefer doing it in another PR to unblock this one

I will upload screenshots for the ui changes