Yelp / mrjob

Run MapReduce jobs on Hadoop or Amazon Web Services
http://packages.python.org/mrjob/
Other
2.62k stars 587 forks source link

_fix_opt() should fix value wrapped by ClearedValue #2102

Closed coyotemarin closed 5 years ago

coyotemarin commented 5 years ago

mrjob.conf.combine_opts() knows what to do with ClearedValue, but existing _fix_opt() methods aren't prepared to deal with ClearedValues (see #2097 for an example).

There's not really any reason writers of _fix_opt() should have to deal with ClearedValue, since it affects how options are combined at a higher level. Instead, _fix_opt() should receive whatever value ClearedValue wraps.