Yelp / mrjob

Run MapReduce jobs on Hadoop or Amazon Web Services
http://packages.python.org/mrjob/
Other
2.62k stars 586 forks source link

make manifest download script handle errors correctly with dash #2175

Closed jgressma closed 4 years ago

jgressma commented 4 years ago

/bin/sh points to dash on Ubuntu 18.04 LTS. The construct

{ VAR=1; } &>/dev/null

doesn't set VAR for dash but it does for bash. Previously the script would (benignly?) succeed, regardless of python's exit code. Here is a typical output prior to this patch: